feat: Remove lead from birdshot

[RobbieNeko]

Purpose of change

Lead is essentially illegal to actually use in birdshot irl in the USA. Plus, it helps to give birdshot a more unique identity, in a sense.

Describe the solution

Changes uncraft to BBs for birdshot, allows for use of BBs in creating it yourself

Describe alternatives you've considered

• Use scrap

As pointed out by Chaos, undesirable

• Remove lead from crafting

Tempting, but unfortunately survivors care little about silly things like EPA regulations or safety other than keeping the zombies off their lawn.

Testing

Loads, is able to be crafted

Additional context

Section on wikipedia explaining lead-free shot

[chaosvolt]

1 scrap metal for a single birdshot shell seems kinda uh...exceedingly wasteful, to be honest. Also muddles things with scrap shot, which makes 2 rounds per 1 scrap metal.

If you want to do this, a better idea would make the uncraft for birdshot default to yielding bismuth, so that shells found in stores are correctly lead-free, while still letting the player craft with lead or bismuth as they please (since the player isn't gonna worry about the EPA coming after them during an apocalypse).

[RobbieNeko]

1 scrap metal for a single birdshot shell seems kinda uh...exceedingly wasteful, to be honest. Also muddles things with scrap shot, which makes 2 rounds per 1 scrap metal.

By weight, I'm actually technically making 10 grams appear out of nowhere based on the bismuth recipe. 1 piece of scrap is 50 grams, whereas 30 bismuth is 60 grams.

If you want to do this, a better idea would make the uncraft for birdshot default to yielding bismuth, so that shells found in stores are correctly lead-free, while still letting the player craft with lead or bismuth as they please (since the player isn't gonna worry about the EPA coming after them during an apocalypse).

In theory, it should yield steel anyway. Bismuth is a really uncommon material choice commercially for it, from what I understand. Most of the birdshot is indeed steel. I suppose I could let the survivor craft them with lead still, but introducing some sort of steel is assuredly a correct idea regardless. Perhaps I should just make it so that BBs are also an option by default alongside the other metals when it comes to crafting birdshot

[chaosvolt]

BBs might be the best option for that, yeah.

[RobbieNeko]

There you go. Birdshot will uncraft into BBs, and you can still use lead for crafting it (alongside, now, BBs)
And original PR body now mostly edited