Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(R) Make 'predict' an S3 method #1657

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

david-cortes
Copy link
Contributor

@david-cortes david-cortes commented Apr 18, 2021

In the R interface, predictions from a model are obtained through function catboost.predict. In most other packages in R, the prediction function is a class method for the model object, so that it can be called with the generic predict - i.e.:

predict(model, data)

vs.

catboost.predict(model, data)

This PR turns it into a class method, keeping the old catboost.predict as a synonym.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@kizill
Copy link
Member

kizill commented May 13, 2021

@arcadia-devtools Ship it!

@kizill
Copy link
Member

kizill commented May 13, 2021

Thank you a lot for this wonderful and really useful changes! 👍

@arcadia-devtools
Copy link
Collaborator

CLA already signed

@arcadia-devtools
Copy link
Collaborator

@kizill, internal review request created: 1776890

@kizill
Copy link
Member

kizill commented Sep 29, 2021

@arcadia-devtools Ship it!

Missing export
@kizill
Copy link
Member

kizill commented Oct 1, 2021

@arcadia-devtools Ship it!

@arcadia-devtools
Copy link
Collaborator

@kizill, internal review request updated: 1776890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants