-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(R) Make 'predict' an S3 method #1657
Open
david-cortes
wants to merge
4
commits into
catboost:master
Choose a base branch
from
david-cortes:predict_as_s3
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arcadia-devtools Ship it! |
Thank you a lot for this wonderful and really useful changes! 👍 |
CLA already signed |
@arcadia-devtools Ship it! |
Missing export
@arcadia-devtools Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the R interface, predictions from a model are obtained through function
catboost.predict
. In most other packages in R, the prediction function is a class method for the model object, so that it can be called with the genericpredict
- i.e.:vs.
This PR turns it into a class method, keeping the old
catboost.predict
as a synonym.I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en