-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Rust crate avoid build #2161
base: master
Are you sure you want to change the base?
Conversation
* If apple arm detected, specificy --target-platform to be CLANG12-DARWIN-ARM64 so that the right libcatboost is built
Also try to make the catboost-sys package standalone so it can be published as a crate
f01e0c3
to
b4aa2e8
Compare
…sed across threads in async
Minor update: As I haven't heard back from the maintainers, and it seems like overkill to fork the whole repo and maintain it, I have opted to split out the code to it's own repository, similar to onnxruntime-rs, since all I need are the files in Instead, to build The crate is published here. Leaving the MR open for now in case the maintainers ever see it. |
Originally had this MR to fix the build for Mac M1. #2160 .
After testing this in my environment, I realised that with the current implementation:
../../libs/model_interface
to allow bindgen to generate the necessary rust bindings. I managed to publish the crate here.Note that for now in build.rs I check for apple + aarch64 before downloading the dylib, as that's the machine I have. I don't have a non-M1 mac to test if that works fine.
Would like to get feedback on whether this is a reasonable approach, and can be merged into master.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.