Compatility fixes for GCC5 #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use inherited constructors, forward manually instead. This basically reverts 61f8031. I believe that GCC5 does not implement P0136, a C++17 change that made inherited constructors actually usable and was backported as a DR all the way to C++11.
Codecov Report
@@ Coverage Diff @@
## devel #2448 +/- ##
==========================================
+ Coverage 91.51% 91.52% +0.01%
==========================================
Files 159 159
Lines 7501 7512 +11
==========================================
+ Hits 6864 6875 +11
Misses 637 637 |
horenmar
reviewed
Jun 5, 2022
horenmar
reviewed
Jun 7, 2022
horenmar
reviewed
Jun 7, 2022
horenmar
reviewed
Jun 7, 2022
|
Thanks for the continued support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use GCC5 in my projects as the oldest GCC compiler to be C++14 conformant. Of course there are a few small issues, but I believe it is a good "oldest" target for C++14.
This PR contains a few changes to fix Catch2v3 compilation with GCC5, which has been broken since v3.0.0-preview5:
std::pairconstructor though I did not explore further to understand where it originally came from.