Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatility fixes for GCC5 #2448

Merged
merged 3 commits into from Jun 7, 2022
Merged

Compatility fixes for GCC5 #2448

merged 3 commits into from Jun 7, 2022

Commits on Jun 5, 2022

  1. GCC5 compat: work around inherited constructor issues 

    Don't use inherited constructors, forward manually instead. This
basically reverts 61f8031.

I believe that GCC5 does not implement P0136, a C++17 change that made
inherited constructors actually usable and was backported as a DR all
the way to C++11.
    @Morwenn
    Morwenn committed Jun 5, 2022
    Copy the full SHA
    74539aa View commit details
    Browse the repository at this point in the history

  2. GCC5 compat: bypass std::pair construction issue

    @Morwenn
    Morwenn committed Jun 5, 2022
    Copy the full SHA
    4ec8b2a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Apply suggestions from code review

    @horenmar
    horenmar committed Jun 7, 2022
    Copy the full SHA
    0ed85c6 View commit details
    Browse the repository at this point in the history