Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress clang-tidy modernize-avoid-c-arrays for TEMPLATE_TEST_CASE #2536

Merged
merged 3 commits into from Sep 26, 2022

Conversation

rutayan
Copy link
Contributor

@rutayan rutayan commented Sep 23, 2022

Description

The why:

I am using catch2 TEMPLATE_TEST_CASE for my project. My project is seeing clang-tidy failures as seen by someone else also #2095.

GitHub Issues

Closes #2095

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #2536 (b6e4e83) into devel (0de60d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2536   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         183      183           
  Lines        7560     7560           
=======================================
  Hits         6922     6922           
  Misses        638      638           

@horenmar horenmar merged commit 97d0b1e into catchorg:devel Sep 26, 2022
@horenmar
Copy link
Member

Thanks

@rutayan
Copy link
Contributor Author

rutayan commented Sep 26, 2022

Thanks for the review! My first open source check-in. I will have a boba-tea for celebration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEMPLATE_TEST_CASE breaks clang-tidy check modernize-avoid-c-arrays
2 participants