Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress clang-tidy modernize-avoid-c-arrays for TEMPLATE_TEST_CASE #2536

Merged
merged 3 commits into from Sep 26, 2022
Merged

Suppress clang-tidy modernize-avoid-c-arrays for TEMPLATE_TEST_CASE #2536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
547d112
Suppress clang-tidy modernize-avoid-c-arrays for TEMPLATE_TEST_CASE
rutayan Sep 23, 2022
5dab39f
Made globalRegistrar a const
rutayan Sep 26, 2022
b6e4e83
Added hicpp-avoid-c-arrays nolint suppression for template tests
rutayan Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/catch2/internal/catch_template_test_registry.hpp
View file
Open in desktop
Expand Up @@ -84,12 +84,12 @@
struct TestName{\
TestName(){\
size_t index = 0; \
constexpr char const* tmpl_types[] = {CATCH_REC_LIST(INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS, __VA_ARGS__)};\
using expander = size_t[];\
constexpr char const* tmpl_types[] = {CATCH_REC_LIST(INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS, __VA_ARGS__)}; /* NOLINT(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,hicpp-avoid-c-arrays) */\
using expander = size_t[]; /* NOLINT(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,hicpp-avoid-c-arrays) */\
(void)expander{(reg_test(Types{}, Catch::NameAndTags{ Name " - " + std::string(tmpl_types[index]), Tags } ), index++)... };/* NOLINT */ \
}\
};\
static int INTERNAL_CATCH_UNIQUE_NAME( globalRegistrar ) = [](){\
static const int INTERNAL_CATCH_UNIQUE_NAME( globalRegistrar ) = [](){\
TestName<INTERNAL_CATCH_MAKE_TYPE_LISTS_FROM_TYPES(__VA_ARGS__)>();\
return 0;\
}();\
Expand Down