Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add semicolon after INFO #1482

Merged
merged 2 commits into from Jan 22, 2019
Merged

Examples: Add semicolon after INFO #1482

merged 2 commits into from Jan 22, 2019

Conversation

JoeyGrajciar
Copy link
Contributor

@JoeyGrajciar JoeyGrajciar commented Jan 1, 2019

Add semicolon after INFO in examples

Description

GitHub Issues

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #1482 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1482   +/-   ##
=======================================
  Coverage   80.39%   80.39%           
=======================================
  Files         121      121           
  Lines        3426     3426           
=======================================
  Hits         2754     2754           
  Misses        672      672

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@61e1ea9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1482   +/-   ##
=========================================
  Coverage          ?   80.53%           
=========================================
  Files             ?      121           
  Lines             ?     3436           
  Branches          ?        0           
=========================================
  Hits              ?     2767           
  Misses            ?      669           
  Partials          ?        0

@horenmar
Copy link
Member

horenmar commented Jan 1, 2019

The change in catch_capture.hpp needs to wait for next major.


Suppressing the warning and changing examples can (and should) go in now though.

@JoeyGrajciar
Copy link
Contributor Author

JoeyGrajciar commented Jan 1, 2019

@horenmar without that change in catch_capture.hpp warning will not be suppressed in case of INFO. unless user explicitly uses the new suppression macro around such usages.

@horenmar
Copy link
Member

horenmar commented Jan 1, 2019

Right, I only read the first two commits. I meant removing the semicolon from INTERNAL_CATCH_INFO.

@JoeyGrajciar
Copy link
Contributor Author

I also meant that :) that will correctly fix the warning

@JoeyGrajciar JoeyGrajciar changed the title Suppress -Wextra-semi-stmt and remove extra semi colon in INTERNAL_CATCH_INFO Examples: Add semicolon after INFO Jan 19, 2019
@JoeyGrajciar JoeyGrajciar merged commit 8d5d54e into catchorg:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants