Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning in extras/CatchAddTests.cmake #2044

Merged
merged 1 commit into from Oct 8, 2020
Merged

fix warning in extras/CatchAddTests.cmake #2044

merged 1 commit into from Oct 8, 2020

Conversation

lkeegan
Copy link
Contributor

@lkeegan lkeegan commented Oct 8, 2020 •
edited

Description

GitHub Issues

@lkeegan
fix warning in extras/CatchAddTests.cmake
c44d9cc 
  - don't warn on zero return code of --list-reporters
  - previously return code was the number of reporters (catchorg#1410, catchorg#1146)
  - as of 2c06ee9 return code is zero on success
@horenmar
Copy link
Member

horenmar commented Oct 8, 2020

Thanks

@horenmar horenmar added the Extras Touches utility scripts outside of Catch2 proper, e.g. CMake integration. label Oct 8, 2020
@horenmar horenmar merged commit 4ea18d6 into catchorg:devel Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extras Touches utility scripts outside of Catch2 proper, e.g. CMake integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lkeegan @horenmar