Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The output of --list-* flags obeys -o flag #2163

Merged
merged 5 commits into from Jan 27, 2021

Commits on Jan 16, 2021

  1. Hold reporter's IConfig instance in the interface

    Previously, every base derived from the IStreamingReporter had
    its own `IConfig const* m_config` member, so this just centralizes
    the handling thereof.
    
    Part of #2061
    horenmar committed Jan 16, 2021
    Copy the full SHA
    74f2f4b View commit details
    Browse the repository at this point in the history
  2. Remove superfluous IConfig argument from IStreamingReporter::list*

    The previous commit made it so that the `IConfig` is stored in
    `IStreamingReporter` and thus always available.
    horenmar committed Jan 16, 2021
    Copy the full SHA
    5509cef View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    7111b2a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Extract the default listing implementation out of reporter interface

    Also generalized the implementations to write to the provided
    output stream, which will be required for the follow up changes,
    where the listings should happen to the location user asked for
    by specifying the `-o` flag.
    horenmar committed Jan 26, 2021
    Copy the full SHA
    6798c13 View commit details
    Browse the repository at this point in the history
  2. --list-* flags write to target specified by the -o flag

    Also added tests for the default implementations of list* reporter
    helpers.
    
    Closes #2061
    horenmar committed Jan 26, 2021
    Copy the full SHA
    971b1fc View commit details
    Browse the repository at this point in the history