Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from AddVectoredExceptionHandler to SetUnhandledExceptionFilter to avoid false positives #2334

Merged
merged 1 commit into from Jan 3, 2022
Merged

Switch from AddVectoredExceptionHandler to SetUnhandledExceptionFilter to avoid false positives #2334

merged 1 commit into from Jan 3, 2022

Commits on Jan 3, 2022

  1. Switch from AddVectoredExceptionHandler to SetUnhandledExceptionFilter 

    This avoids issues with Catch2's handler firing too early, on
structured exceptions that would be handled later. This issue
meant that the old attempts at structured exception handling
were incompatible with Windows's ASan, because it throws
continuable `C0000005` exception, which it then handles.

With the new handling, Catch2 is only notified if nothing else,
including the debugger, has handled the exception.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

Closes #2332
Closes #2286
Closes #898
    @Alan-Jowett @horenmar
    Alan-Jowett authored and horenmar committed Jan 3, 2022
    Copy the full SHA
    f004061 View commit details
    Browse the repository at this point in the history