Refactor MatchersRanges test utils #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not hardcode content of containers - prefix members with m_ - add const and non-const iterators to with_mocked_iterator_access
|
fwiw you can also just store the elements in a vector and use init-list constructor to init the types |
Codecov Report
@@ Coverage Diff @@
## devel #2386 +/- ##
==========================================
- Coverage 91.04% 91.03% -0.01%
==========================================
Files 152 154 +2
Lines 7313 7290 -23
==========================================
- Hits 6658 6636 -22
+ Misses 655 654 -1 |
horenmar
reviewed
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor test util classes in MatchersRanges.tests. This is preparatory work for #2319.
m_with_mocked_iterator_access