fix(spotify-web): various unthemed elements #879
+84
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Papweer
changed the title
Papweer
changed the title
|
Please follow the https://www.conventionalcommits.org/en/v1.0.0/ format for titling your pull request. In this case, the type of change is a |
Papweer
changed the title
uncenter
changed the title
uncenter
reviewed
Jun 6, 2024
Comment on lines
+301
to
+372
| // Cookie Banner | ||
| #onetrust-banner-sdk { | ||
| background-color: @base !important; | ||
| color: @text !important; | ||
| } | ||
| #onetrust-policy-text, .ot-dpd-title, .onetrust-policy-title, .ot-text-bold { | ||
| color: @text !important; | ||
| } | ||
| .ot-dpd-desc, .ot-link-btn { | ||
| color: @text !important; | ||
| } | ||
| #onetrust-consent-sdk #onetrust-policy-title { | ||
| color: @text !important; | ||
| } | ||
| #onetrust-banner-sdk button { | ||
| color: @text !important; | ||
| } | ||
| #onetrust-pc-btn-handler { | ||
| background-color: @base !important; | ||
| } | ||
| // Cookie Settings | ||
| #onetrust-consent-sdk #onetrust-pc-sdk, | ||
| .ot-acc-txt, .ot-acc-grpdesc{ | ||
| background-color: @base !important; | ||
| } | ||
| #onetrust-consent-sdk #onetrust-pc-sdk #ot-pc-title, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk #ot-pc-desc, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk h3, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk h5, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk h4, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk h6, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk h2, | ||
| #onetrust-pc-sdk .ot-always-active, | ||
| .ot-acc-txt, .ot-acc-grpdesc, | ||
| #onetrust-consent-sdk #onetrust-pc-sdk p{ | ||
| color: @text !important; | ||
| } | ||
| #onetrust-pc-sdk .ot-accordion-layout.ot-cat-item { | ||
| border-color: @accent-color !important; | ||
| } | ||
| #onetrust-consent-sdk #onetrust-pc-sdk button:not(#clear-filters-handler):not(.ot-close-icon):not(#filter-btn-handler):not(.ot-remove-objection-handler):not(.ot-obj-leg-btn-handler):not([aria-expanded]):not(.ot-link-btn) { | ||
| background-color: @accent-color !important; | ||
| border-color: @accent-color !important; | ||
| } | ||
| #onetrust-pc-sdk .ot-accordion-layout.ot-cat-item { | ||
| border-radius: 8px; | ||
| } | ||
| // Vendors List | ||
| #onetrust-consent-sdk #onetrust-pc-sdk .ot-sel-all-hdr span { | ||
| color: @text; | ||
| } | ||
| #onetrust-pc-sdk input[type=text] { | ||
| background-color: @mantle !important; | ||
| border-color: @accent-color !important; | ||
| } | ||
| #onetrust-pc-sdk .ot-pc-header, | ||
| #onetrust-pc-sdk ul li{ | ||
| border-bottom-color: @accent-color !important; | ||
| border-top-color: @accent-color !important; | ||
| } | ||
| #ot-ven-lst { | ||
| border-top-color: @accent-color !important; | ||
| } | ||
| .ot-pc-footer { | ||
| border-top-color: @accent-color !important; | ||
| } | ||
| #onetrust-pc-sdk li>button { | ||
| border-top-color: @accent-color !important; | ||
| } | ||
| #onetrust-consent-sdk #onetrust-pc-sdk #ot-sel-blk { | ||
| background-color: @base !important; | ||
| } |
There was a problem hiding this comment.
cc @isabelroses I actually themed this for Stack Overflow (
userstyles/styles/stack-overflow/catppuccin.user.css
Lines 313 to 406 in c977d9e
@import lines for userstyles that involve websites with the OneTrust cookie consent popup?
There was a problem hiding this comment.
Ohhh this is interesting. Heres my idea. We create a "common" dir and place commonalities between themes and publish them there. But I'll admit this maybe a bit overkill and just repeating the same style here might be easier.
There was a problem hiding this comment.
I definitely don't want to repeat this though. Common isn't a bad idea, I have a userstyle on my Windows machine that applies scrollbar fixes to all websites with regex('*'), could do something similar with the common/ directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 What does this fix? 🔧
Themes the previously unthemed Accept Cookies banner, vendors info popup and the signup banner. Also fixes the left sidebar background on the main page being unthemed.
fixes #834 and also fixes #826
🗒 Checklist 🗒
==UserStyle==header of thecatppuccin.user.cssfile.