Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spotify-web): various unthemed elements #879

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Papweer
Copy link

@Papweer Papweer commented May 9, 2024

🔧 What does this fix? 🔧

Themes the previously unthemed Accept Cookies banner, vendors info popup and the signup banner. Also fixes the left sidebar background on the main page being unthemed.
fixes #834 and also fixes #826

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@Papweer Papweer requested a review from Tnixc as a code owner May 9, 2024 13:34
@github-actions github-actions bot added the spotify-web Spotify Web label May 9, 2024
@Papweer Papweer changed the title Some fixes for Spotify-Web Feat Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. May 9, 2024
@Papweer Papweer changed the title Feat Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. feat: Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. May 9, 2024
@uncenter
Copy link
Member

uncenter commented May 9, 2024

Please follow the https://www.conventionalcommits.org/en/v1.0.0/ format for titling your pull request. In this case, the type of change is a fix, the scope should be spotify-web, and the body should be a very succinct summary of your changes.

@Papweer Papweer changed the title feat: Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. fix(spotify-web): Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. May 12, 2024
@uncenter uncenter changed the title fix(spotify-web): Added theming for Cookie Banner, Vendors Info and Signup Banner. Also Fixed Background of Left Sidebar. fix(spotify-web): various unthemed elements Jun 6, 2024
@uncenter uncenter requested a review from isabelroses June 6, 2024 13:21
@Tnixc
Copy link
Member

Tnixc commented Jun 6, 2024

image We still have some unthemed elements, we might want to theme those as well before we merge

Papweer and others added 2 commits June 7, 2024 19:40
- Dropdown menus.
- Some icons on the main bottom bar.
- Fullscreen lyrics, playing next and bottom bar icons.
@Papweer
Copy link
Author

Papweer commented Jun 7, 2024

I themed the unthemed elements mentioned above and a few more. Not sure what to do with the cookie banner theming but for now I just left it in.

@Tnixc
Copy link
Member

Tnixc commented Jun 7, 2024

image

image

Glad you fixed the elements above. There's still some minor things to fix here. Make sure you update the version from 0.0.1 to 0.0.2, It seems like its gone back to 0.01 in your latest commit.

@uncenter
Copy link
Member

uncenter commented Jun 7, 2024

I themed the unthemed elements mentioned above and a few more. Not sure what to do with the cookie banner theming but for now I just left it in.

Yeah sorry about that random discussion. Leave it in for now, I'll make a PR changing it if we decide on something :)

@Papweer
Copy link
Author

Papweer commented Jun 8, 2024

I themed the remaining elements. I couldn't find any other unthemed elements but I might have missed some.

@Papweer
Copy link
Author

Papweer commented Jun 8, 2024

I fixed the linting errors. I think it's ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spotify-web Spotify Web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spotify: unthemed elements Spotify unthemed background behind sidebar elements
4 participants