Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roblox): init #655

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

ThatOneUnoriginal
Copy link

A Catppuccin theme designed for the roblox.com website with support for RoPro, RoGold, RoSeal and BTRoblox third party extensions. First time creating a pull request so I hope I'm doing this correctly (along with everything else.)

@ThatOneUnoriginal ThatOneUnoriginal changed the title Website: Add Catppuccin to Roblox feat: Add Catppuccin to Roblox Mar 12, 2024
@ThatOneUnoriginal ThatOneUnoriginal changed the title feat: Add Catppuccin to Roblox feat: Add Catppuccin Support to Roblox Mar 12, 2024
@ThatOneUnoriginal ThatOneUnoriginal changed the title feat: Add Catppuccin Support to Roblox feat(roblox): init Mar 12, 2024
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
@kingofcube
Copy link

kingofcube commented Mar 13, 2024

was thinking of making one tho, is it allowed to put someone's else userstyle of the same website to the roblox repo?
its actually pretty good, might actually use it

@uncenter
Copy link
Member

was thinking of making one tho

You had your chance lol.

is it allowed to put someone's else userstyle of the same website to the roblox repo?

What is "the roblox repo"?

@ThatOneUnoriginal
Copy link
Author

ThatOneUnoriginal commented Mar 13, 2024

was thinking of making one tho

Wasn't aware of your efforts of creating a Roblox Catppuccin theme when initially starting mine. Just saw that there wasn't any officially listed and decided I'd do it myself. By the time someone mentioned the existence of the one you were curating, I had already finished pretty much all the theming for the website.

Throughout the final stretch of theming I did take a few ideas from your theme and implemented into mines (primarily having more buttons affected by the accent color.) So please don't think your efforts in curating your own version were fruitless. If it weren't for it the theme probably would had featured the accent color a lot less then it did initially (I believe initially I only had it so that the play buttons were affected by the accent color.)

@kingofcube
Copy link

kingofcube commented Mar 13, 2024

was thinking of making one tho

Wasn't aware of your efforts of creating a Roblox Catppuccin theme when initially starting mine. Just saw that there wasn't any officially listed and decided I'd do it myself. By the time someone mentioned the existence of the one you were curating, I had already finished pretty much all the theming for the website.

Throughout the final stretch of theming I did take a few ideas from your theme and implemented into mines (primarily having more buttons affected by the accent color.) So please don't think your efforts in curating your own version were fruitless. If it weren't for it the theme probably would had featured the accent color a lot less then it did initially (I believe initially I only had it so that the play buttons were affected by the accent color.)

mkay, i didn't like how the theme looked tho
but eh, that's just my opinion, I dont like super dark themes anyway
also I suggest you could add addon support (btrroblox, ropro, rogold, etc)

@kingofcube
Copy link

kingofcube commented Mar 13, 2024

was thinking of making one tho

You had your chance lol.

is it allowed to put someone's else userstyle of the same website to the roblox repo?

What is "the roblox repo"?

I misunderstood it, I meant the roblox userstyle repo xd

styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

Screenshot 2024-03-13 at 16 30 44 (Arc)

Search bar appears unthemed based on your preview image.

@ThatOneUnoriginal
Copy link
Author

Screenshot 2024-03-13 at 16 30 44 (Arc)

Search bar appears unthemed based on your preview image.

Oh yes it would appear so. I suppose I grabbed the screenshots for the preview images before I had decided that the input boxes should be themed as well. I will fix this after making changes to the theme (found a few elements that went overlooked as well.)

scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Outdated Show resolved Hide resolved
styles/roblox/catppuccin.user.css Show resolved Hide resolved
ThatOneUnoriginal and others added 2 commits April 12, 2024 18:04
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from the CSS itself. I'll try to test it out today or tomorrow.

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-12 at 19 07 04 (Arc)

Sign up page is almost entirely unthemed.

@uncenter
Copy link
Member

Screenshot 2024-04-12 at 19 09 39 (Arc)

@uncenter
Copy link
Member

My Settings > Login Methods:
Screenshot 2024-04-12 at 19 12 24 (Arc)

My Settings > Personal > Birthday:
Screenshot 2024-04-12 at 19 14 34 (Arc)

Text color should be crust all the time, background-color should darken on hover.

My Settings > Security > 2 Step Verification:
Screenshot 2024-04-12 at 19 15 41 (CleanShot)

Barely visible toggles.

Avatar Editor:
Screenshot 2024-04-12 at 19 17 33 (Arc)

Other:
Screenshot 2024-04-12 at 19 19 16 (CleanShot)

Unthemed verified checkmark.

@ThatOneUnoriginal
Copy link
Author

ThatOneUnoriginal commented Apr 13, 2024

Other: Screenshot 2024-04-12 at 19 19 16 (CleanShot)

Unthemed verified checkmark.

Like with the navigation icons, from what I recall the verification icon is an svg being loaded from Roblox's servers and seeing as there are issues with trying to replace the navigation icons, I would only assume said issues will persist with the verification icon (I will see if that is the case though, but I suspect that it would.)

@uncenter
Copy link
Member

Other: Screenshot 2024-04-12 at 19 19 16 (CleanShot)
Unthemed verified checkmark.

Like with the navigation icons, from what I recall the verification icon is an svg being loaded from Roblox's servers and seeing as there are issues with trying to replace the navigation icons, I would only assume said issues will persist with the verification icon (I will see if that is the case though, but I suspect that it would.)

Definitely themeable :)

Screenshot 2024-04-13 at 18 33 20 (Arc)

@ThatOneUnoriginal
Copy link
Author

Screenshot 2024-04-12 at 19 09 39 (Arc)

Unfortunately I'm experiencing the same problem with the Roblox icon as with the navigation icons.
image

@uncenter
Copy link
Member

Screenshot 2024-04-12 at 19 09 39 (Arc)

Unfortunately I'm experiencing the same problem with the Roblox icon as with the navigation icons. image

Why are you not using https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#img-elements ?

@ThatOneUnoriginal
Copy link
Author

Screenshot 2024-04-12 at 19 09 39 (Arc)

Unfortunately I'm experiencing the same problem with the Roblox icon as with the navigation icons. image

Why are you not using https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#img-elements ?

I was testing to see if it would work, I wasn't aware at the time that doing it that way would result in a different outcome. Have tried it now and it works. I'm guessing this wouldn't be possible for the navigation icons since its multiple icons in one instead of just one icon like with the Roblox icon/logo?

@uncenter
Copy link
Member

Screenshot 2024-04-12 at 19 09 39 (Arc)

Unfortunately I'm experiencing the same problem with the Roblox icon as with the navigation icons. image

Why are you not using https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#img-elements ?

I was testing to see if it would work, I wasn't aware at the time that doing it that way would result in a different outcome. Have tried it now and it works. I'm guessing this wouldn't be possible for the navigation icons since its multiple icons in one instead of just one icon like with the Roblox icon/logo?

As I've mentioned in the past, it should work for the navigation icons if you don't change the sizing or padding or add/remove any icons.

@ThatOneUnoriginal
Copy link
Author

Screenshot 2024-04-12 at 19 09 39 (Arc)

Unfortunately I'm experiencing the same problem with the Roblox icon as with the navigation icons. image

Why are you not using https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#img-elements ?

I was testing to see if it would work, I wasn't aware at the time that doing it that way would result in a different outcome. Have tried it now and it works. I'm guessing this wouldn't be possible for the navigation icons since its multiple icons in one instead of just one icon like with the Roblox icon/logo?

As I've mentioned in the past, it should work for the navigation icons if you don't change the sizing or padding or add/remove any icons.

How would you replicate the svg file using the @svg: escape("<svg>...</svg>"); method? It has multiple icons in one unlike smth like the Roblox icon or logo.

@uncenter
Copy link
Member

.verified-badge-icon-experience-creator {
  @svg: escape('<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"><path fill="@{accent-color}" d="M3.365 0 -0.02 12.634l12.634 3.385 3.385 -12.634zm7.752 4.743a0.88 0.88 0 0 1 0.622 0.257l0.003 0.005a0.88 0.88 0 0 1 0 1.243l-4.99 4.989 -2.495 -2.495a0.88 0.88 0 0 1 0 -1.243l0.005 -0.003a0.88 0.88 0 0 1 1.243 0l1.247 1.249 3.743 -3.743a0.88 0.88 0 0 1 0.622 -0.257"/></svg>');
  content: url("data:image/svg+xml,@{svg}");
}

…d Disabled Toggle Circle; Fixed Avator Editor Subcategory Hover Background; Added Accent Color to Verification Icon (Thanks Uncenter); Themed Roblox Icon + Logo; Fixed Problems in Login and Sign Up Page.
@ThatOneUnoriginal
Copy link
Author

ThatOneUnoriginal commented Apr 16, 2024

Not all of the icons are completed, should get that mostly (if not totally) done by tomorrow. Also I would like to know what ya'll think of having the Roblox icon/logo be @accent-color instead of @text. I'm impartial to whichever is seen as the better choice but I prefer the accent-color for the Roblox logo/icon.

@uncenter
Copy link
Member

Not all of the icons are completed, should get that mostly (if not totally) done by tomorrow. Also I would like to know what ya'll think of having the Roblox icon/logo be @accent-color instead of @text. I'm impartial to whichever is seen as the better choice but I prefer the accent-color for the Roblox logo/icon.

Yes it should be accent.

@uncenter uncenter marked this pull request as draft April 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants