Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(twitter): misc, support shinigami eyes extension #753

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

watatomo
Copy link
Member

@watatomo watatomo commented Apr 3, 2024

No description provided.

@github-actions github-actions bot added the twitter Twitter label Apr 3, 2024
@watatomo watatomo self-assigned this Apr 3, 2024
@isabelroses
Copy link
Member

@watatomo is this ready for review?

@uncenter uncenter changed the title fix(twitter): some edits and also added shinigami eyes support fix(twitter): misc, support shinigami eyes extension Apr 7, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it if we didn't use new @-moz-documents for each "section" or feature of a website. Let's try to keep it all in one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to contain all the metadata and maybe more from the trinket theme and not the twitter theme.

@isabelroses isabelroses marked this pull request as draft April 15, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
twitter Twitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants