feat(google-classroom): init

[BomberFish]

🎉 Theme for Google Classroom 🎉

💬 Additional Comments 💬

N/A

🗒 Checklist 🗒

• I have read and followed Catppuccin's submission guidelines.
• I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
  • I have ensured that the new directory is in lower-kebab-case.
  • I have followed the template and kept the preprocessor as LESS.
• I have made sure to update the
  userstyles.yml
  file with information about the new userstyle.
• I have included the following files:
  • catppuccin.user.css - all the CSS for the userstyle, based on the
    template.
  • preview.webp - composite image of all four individual flavor screenshots stitched together,
    generated via Catwalk.

[isabelroses]

Thanks for the PR looks like it was a lot of work.

I've left a few comments but in addition to that theres a lot of places where my comments apply you should ideally abstract them out to the rest of the css.

We also have a deno task that can fix some of the errors the linter is throwing you can run this by using deno task lint:fix. You can also run our linter locally with deno task lint before pushing to check the status.

[BomberFish]

All the issues should be resolved by now. Also completely removed the force accent color option, it didn't look that great anyways.

[isabelroses]

All the issues should be resolved by now. Also completely removed the force accent color option, it didn't look that great anyways.

Hum, the linter still seems to be throwing serval errors.

[BomberFish]

Weird... I'll try and fix it sometime today.

[uncenter]

You can view the "lint annotations" by scroll down to the diff under the "Files changed" tab.

[BomberFish]

Should be good to merge now, lint succeeds on my machine.

[BomberFish]

Should be good now.

[BomberFish]

this is ready again btw

[uncenter]

A few observations from the preview image:

[ThatOneUnoriginal]

A few observations from the preview image:

From my observations those aren't affected from the @accent-color choice, staying blue the entire time (as shown bellow)

The only UI I see getting modified by the @accent-color is the selection color for which part of the website you're in (except for the classrooms themselves, they keep their original colours) and the create classroom button (which would be useless for most people anyway, but I digress)

[ThatOneUnoriginal]

In the Calendar section the dropdown menu to select a specific class is not themed correctly (edit: same applies to the drop down in the "To-do" section. Additionally the dropdown in the "Open your work for [xyz]" is hit with the same problem.)

The lines that show up for archived classes in the Archived Classes sections looks weird

The grade for assignments is not themed.

The :focus element state for these buttons are not themed.

In the "Open your work for [xyz]" section the dropdown to view the attached work and view details of the assignment are not themed.

[uncenter]

Thanks for reviewing @ThatOneUnoriginal!

[BomberFish]

Sorry I haven't been able to do much with this lately, been a bit busy lately.

I was able to fix the issues with the "view your work" tab and the calendar. The archived classes issue seems to be a issue with Classroom itself, don't know how to fix that. I'll look into the accent color option later.

[BomberFish]

Hey all, I've been able to find some extra time to work on the style. I've been able to fix the issue with the tab focus state and fix the Google Apps button, which seemed to be broken recently.

[uncenter]

Hey all, I've been able to find some extra time to work on the style. I've been able to fix the issue with the tab focus state and fix the Google Apps button, which seemed to be broken recently.

Sweet! Is it ready for review again? I think that was everything so this should be close to merging.

[BomberFish]

Sweet! Is it ready for review again? I think that was everything so this should be close to merging.

Pretty much, although I'm not entirely sure how to handle the user's accent preference since stock Classroom changes its accent depending on the selected class

[isabelroses]

Sweet! Is it ready for review again? I think that was everything so this should be close to merging.

Pretty much, although I'm not entirely sure how to handle the user's accent preference since stock Classroom changes its accent depending on the selected class

That's pretty quirky. If theres a few vars e.g. --accent-red, --accent-green then I think its good to just theme those and ignore the user preference and just theme those.

[BomberFish]

I believe that's what it does already, so should be good for review.

[uncenter]

Probably hard to recreate this popup but is unthemed.

This is unthemed for me? Looks like a new issue.

"Join class" button is unthemed.

This logo can be themed, see https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#how-do-i-theme-images-and-svgs if needed.

Settings page, divider is unthemed and the toggles should match the unthemed ones better:

The whole change profile picture workflow is unthemed as well.

[isabelroses]

The css seems reasonable but I have no way to see the website.

[BomberFish]

Are you sure the tabs are broken? Works fine on my machine

[uncenter]

Are you sure the tabs are broken? Works fine on my machine

Yep pretty sure!

[uncenter]

Feel free to re-request a review from me once the changes pointed out are fixed :)