Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hoist current/past-maintainers keys up #811

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

sgoudham
Copy link
Contributor

This PR hoists the current-maintainers and past-maintainers keys up, outside of the readme. I didn't put much thought about it being under readme at the time since it didn't really matter but this change makes it more consistent with the ports.yml in catppuccin/catppuccin.

The main benefit of this change is so that it's somewhat less verbose to retrieve the maintainers from both userstyles and ports if you aren't validating via the schema.

Draft until I update the docs. (I also did this while having dead time on holiday and will be away the next few days so happy for others to push to this PR before I come back to it)

@uncenter
Copy link
Member

Could also be worth moving readme.app_link to url to match the ports.yml schema?

@uncenter uncenter marked this pull request as ready for review June 2, 2024 15:01
Copy link
Contributor Author

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs.

I think the url change sounds fine, best for another PR if anything.

@uncenter
Copy link
Member

uncenter commented Jun 2, 2024

Sounds good, I'll do it in a follow up PR. If my docs commit was enough for you this is good to merge I think!

@uncenter uncenter requested a review from isabelroses June 2, 2024 17:10
@sgoudham sgoudham merged commit 6ca6c43 into main Jun 2, 2024
6 checks passed
@sgoudham sgoudham deleted the chore/hoist-current-maintainers branch June 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants