Skip to content

Commit

Permalink
test: Fix Tizen src= test (video-dev#4452)
Browse files Browse the repository at this point in the history
The test to show that src= playbacks can log width/height data was
failing on Tizen.  This is because Tizen was ignoring the SAR (sample
aspect ratio) and showing the content at 256 pixels wide, whereas
other platforms were displaying at 258 pixels wide.  The point of the
test was never to check a platform's support for SAR, so the video has
been re-encoded to display consistently across platforms.

This issue began when the test was added in PR video-dev#4435.

The video file is now also much smaller than it was before (from 177kB
to 37kB).

Re-encoding was done with:

```sh
ffmpeg \
  -i test/test/assets/small.mp4.orig \
  -c:v h264 -vf setsar=1:1 -crf 51 \
  -c:a aac -b:a 16k \
  -y test/test/assets/small.mp4
```
  • Loading branch information
joeyparrish committed Aug 30, 2022
1 parent 91003d3 commit 6b56ed7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/player_src_equals_integration.js
Expand Up @@ -306,7 +306,7 @@ describe('Player Src Equals', () => {
expect(stats.manifestTimeSeconds).toBeNaN(); // There's no manifest.
expect(stats.drmTimeSeconds).toBeNaN(); // There's no DRM.
expect(stats.height).toBe(110);
expect(stats.width).toBe(258);
expect(stats.width).toBe(256);
});

it('plays with external text tracks', async () => {
Expand Down
Binary file modified test/test/assets/small.mp4
Binary file not shown.

0 comments on commit 6b56ed7

Please sign in to comment.