fix(HLS): Ensure textSequenceModeOffset is updated on each offset calculation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdharris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
PR just to review diff of changes.
This resolves AVIAJS-10, captions sync issue with Pluto HLS streams.
time.periodStartin vtt_text_parser, was calculated and set at stream start and never updated.textEngine_.setTimestampOffset) in order to updatetime.periodStart, it only ever uses the initial calculated offset.this.textSequenceModeOffset_is typed and initiated as a Promise. The value is updated by callingthis.textSequenceModeOffset_.resolve(value). However, once a promise is resolved, calling resolve on it again has no effect. So the first value passed is locked in and used in all subsequent calculations.this.textSequenceModeOffset_type from a Promise to a number and directly updates it's value on eachappendBufferof type video.