-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure code as Python package 📦 #22
base: master
Are you sure you want to change the base?
feat: restructure code as Python package 📦 #22
Conversation
…rblz/ccl_chrome_indexeddb into chore/restructure-as-module
Hi, thanks for this. Let me sit with this for a couple of days because I'm wondering if this is an opportunity to fix a "problem" with this module - i.e. the level_db support (and its dependencies) probably should live outside of what is otherwise a specifically Chrome focussed module, given that it is used much more widely than just Chrome. My concern there is that might be a breaking change too far for folks who are already using the libraries in other projects (although this change will require at least some changes to other users' code I suppose). As this is your PR, I'd welcome your views of course. |
@cclgroupltd That makes perfect sense. The reason why I had proposed this change, was because I found it rather hard to integrate the repo in one of my projects, without copying the code. However, I also understand your point that it would inadvertently lead to some breaking changes for current users. Unfortunately, I don't have a solution for that problem yet, but I'll give it some thought. |
Hello Alex,
in this PR I propose a slight refactoring of the project setup that allows to use the code as a Python module.
This has two main benefits:
For option 2, the git repo could simply be added as a dependency in the pyproject.toml:
Please let me know what you think.