Merge pull request #40 from ccremer/util

Add AddStepFromFunc convenience method

pipeline.go

@@ -64,6 +64,11 @@ func (p *Pipeline) AddStep(step Step) *Pipeline {
 	return p
 }
 
+// AddStepFromFunc appends the given function to the Pipeline at the end and returns itself.
+func (p *Pipeline) AddStepFromFunc(name string, fn func(ctx context.Context) error) *Pipeline {
+	return p.AddStep(NewStepFromFunc(name, fn))
+}
+
 // WithSteps appends the given array of steps to the Pipeline at the end and returns itself.
 func (p *Pipeline) WithSteps(steps ...Step) *Pipeline {
 	p.steps = steps

pipeline_test.go

@@ -171,18 +171,17 @@ func TestPipeline_Run(t *testing.T) {
 }
 
 func TestPipeline_RunWithContext_CancelLongRunningStep(t *testing.T) {
-	p := NewPipeline().WithSteps(
-		NewStepFromFunc("long running", func(ctx context.Context) error {
-			for {
-				select {
-				case <-ctx.Done():
-					return ctx.Err()
-				default:
-					// doing nothing
-				}
+	p := NewPipeline().AddStepFromFunc("long running", func(ctx context.Context) error {
+		for {
+			select {
+			case <-ctx.Done():
+				return ctx.Err()
+			default:
+				// doing nothing
 			}
-		}),
-	)
+		}
+	})
+
 	ctx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
 	go func() {
 		time.Sleep(5 * time.Millisecond)