NameSpaceAdmin feature design and Runtime scenario addition. #15397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahuldash171
force-pushed
the
Cdap_NSAdmin_Features
branch
from
2e56d59
to
6105812
Compare
GnsP
requested changes
Jan 19, 2024
| Then Enter input plugin property: "host" with value: "testHost" | ||
| Then Enter input plugin property: "user" with value: "testUser" | ||
| Then Enter textarea plugin property: "sshKey" with value: "testSSHKey" | ||
| Then Click on: "Create" button in the properties |
There was a problem hiding this comment.
This seems to be a case of locating the button using the text content of the button. We should avoid this.
Comment on lines
+75
to
+82
| BigQueryClient.getSoleQueryResult("create table `" + datasetName + "." + bqSourceTable + "` as " + | ||
| "SELECT * FROM UNNEST([ " + | ||
| " STRUCT(1 AS Id, " + ((int) (Math.random() * 1000 + 1)) + " as Value, " + | ||
| "'" + UUID.randomUUID() + "' as UID), " + | ||
| records + | ||
| " (26, " + ((int) (Math.random() * 1000 + 1)) + ", " + | ||
| "'" + UUID.randomUUID() + "') " + | ||
| "])"); |
There was a problem hiding this comment.
Consider formatting the query string for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New design and runtime scenarios for Namespace admin module