Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cloudquery full scan #256

Merged
merged 3 commits into from Apr 4, 2023
Merged

Feat/cloudquery full scan #256

merged 3 commits into from Apr 4, 2023

Conversation

gcharest
Copy link
Contributor

@gcharest gcharest commented Apr 4, 2023

Summary | Résumé

  • Enable full asset discovery
  • Skip tables with configuration parameters
  • Enable s3 bucket versioning

@gcharest gcharest requested a review from a team April 4, 2023 20:17
@gcharest gcharest self-assigned this Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

cloud_asset_inventory

✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.cloudquery_s3_bucket.aws_s3_bucket.this will be updated in-place
  ~ resource "aws_s3_bucket" "this" {
        id                          = "security-tools-794722365809-cloudquery-results"
        tags                        = {
            "CostCentre" = "security-tools-794722365809"
            "Critical"   = "false"
            "Terraform"  = "true"
        }
        # (11 unchanged attributes hidden)



      ~ versioning {
          ~ enabled    = false -> true
            # (1 unchanged attribute hidden)
        }
        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.cloudquery_s3_bucket.aws_s3_bucket.this,
  on .terraform/modules/cloudquery_s3_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
   8: resource "aws_s3_bucket" "this" {

Use the aws_s3_bucket_server_side_encryption_configuration resource instead

(and 3 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.cloudquery"]

18 tests, 17 passed, 1 warning, 0 failures, 0 exceptions

Copy link
Member

@CalvinRodo CalvinRodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮🐱

@gcharest gcharest merged commit 9763fed into main Apr 4, 2023
6 checks passed
@gcharest gcharest deleted the feat/cloudquery-full-scan branch April 4, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants