Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: bin_stream::get_u8 method returning bytes #1487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: bin_stream::get_u8 method returning bytes #1487

wants to merge 1 commit into from

Conversation

psyirius
Copy link

@psyirius psyirius commented Apr 27, 2024 •
edited

bin_stream::get_u8 supposed to be returning an int.
but instead it returns a bytes object

Not sure how the dependent callers are expecting!

@psyirius
Copy link
Author

psyirius commented Apr 28, 2024 •
edited

@serpilliere Is there any way you can review and merge it as soon as possible.
Workaround code for essential stuff is not gonna look good in production. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@psyirius