Remove depreciated name tags in A element #180
Conversation
|
Any chance to get this merged? Minor issue, but it produces HTML that does not validate. Apparently GitHub has a lot of bad html, and it changes, so look for issues 185 - 191 here: https://validator.w3.org/nu/?doc=https%3A%2F%2Fgithub.com%2Fcebe%2Fmarkdown The rest of the errors are GitHub issues. You may also be able to see just the errors in the readme.md file here: https://validator.w3.org/nu/?doc=http%3A%2F%2Fphpfui.com%2F%3Fn%3Dcebe%255Cmarkdown, but I sometimes clean them up. Thanks! |
| @@ -7,7 +7,7 @@ A super fast, highly extensible markdown parser for PHP | |||
| [](https://scrutinizer-ci.com/g/cebe/markdown/) | |||
| [](https://scrutinizer-ci.com/g/cebe/markdown/) | |||
|
|
|||
| What is this? <a name="what"></a> | |||
| What is this? | |||
There was a problem hiding this comment.
This might break existing links (i.e. the only available ID there now will be #what-is-this- instead of #what). How about changing it to <span id="what"></span> instead? That validates, and keeps existing links working. (Same for the other ones below.)
There was a problem hiding this comment.
I really don't care as long as it is valid HTML. It is currently not valid. You want me to revise?
There was a problem hiding this comment.
I'm not a maintainer here, so it's not my call, but I'd say it'd be best to maintain backwards compatibility.
This PR cleans up a minor issue in README.md that produces a warning from w3.org. See lines 130-136 in https://validator.w3.org/nu/?doc=https%3A%2F%2Fgithub.com%2Fcebe%2Fmarkdown
The A elements don't really add anything and are not needed.