Fix broken build. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ceifa#80. According to git bisect, the build was broken in revision f27b4a8, which added `callback.rs`. Specifically, `callback.rs` added a `pub enum SteamCallback`. Any NAPI-RS file that exports an enum requires you to `use napi::bindgen_prelude::ToNapiValue`, which it did, but it also requires you to use `FromNapiValue`. As far as I can tell, this has always been true, even back at revision f27b4a8. The parent revision to f27b4a8 deleted `Cargo.lock`, but even when I brought `Cargo.lock` back, it _still_ required `FromNapiValue`. So, I have no idea why the build has been working at all for the last year, but this definitely seems to fix it.
|
Great find, actually I think this is happening because of napi-rs/napi-rs#1551 |
|
The Github builds have passed! Please merge at your earliest convenience. |
|
The duplication thing is happening since 2.15.1 IIRC: napi-rs/napi-rs#1531 |
I assume you mean 2.15.0! Yes, we can do a smaller downgrade, from 2.15.2 to 2.15.0, and that also fixes #83. I've force pushed that change. Let's merge this PR as soon as those builds pass. |
|
Builds pass! 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80 and #83.
According to git bisect, the build was broken in revision f27b4a8, which added
callback.rs.Specifically,
callback.rsadded apub enum SteamCallback. Any NAPI-RS file that exports an enum requires you touse napi::bindgen_prelude::ToNapiValue, which it did, but it also now requires you to useFromNapiValue.As far as I can tell, this has always been true, even back at revision f27b4a8. The parent revision to f27b4a8 deletedCargo.lock, but even when I broughtCargo.lockback, it still requiredFromNapiValue.So, I have no idea why the build has been working at all for the last year, but addingFromNapiValueeverywhereToNapiValueis used definitely seems to fix it.EDIT: Oops, I was accidentally restoring the wrong
Cargo.lockfile. Restoring theCargo.lockfile from 56e80a4 into revision f27b4a8 also fixes the build. I've filed PR #84 to bring back aCargo.lockfile so reproducibility issues like this don't happen in the future.Furthermore, I've downgraded
@napi-rs/clito fix #83.