Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs build failure #7835

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Oct 19, 2022

Closes #7783 #7834 #7833

Fix doc build failure:

  • kombu>=5.3.0b2
  • make sure readthedocs builds with the proper dependencies

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 89.77% // Head: 89.77% // No change to project coverage 👍

Coverage data is based on head (4df1105) compared to base (1da6c28).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7835   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         128      128           
  Lines       15784    15784           
  Branches     2111     2111           
=======================================
  Hits        14170    14170           
  Misses       1386     1386           
  Partials      228      228           
Flag Coverage Δ
unittests 89.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woutdenolf woutdenolf marked this pull request as ready for review October 19, 2022 17:48
This was referenced Oct 19, 2022
@woutdenolf woutdenolf changed the title Kombu 5.3.0b2 Fix readthedocs build failure Oct 19, 2022
@woutdenolf
Copy link
Contributor Author

Remaining CI failures are unrelated: #7836

@Nusnus Nusnus requested review from thedrow and auvipy October 19, 2022 21:43
@auvipy auvipy merged commit c9b593f into celery:master Oct 20, 2022
@auvipy auvipy added this to the 5.3 milestone Oct 20, 2022
@auvipy
Copy link
Member

auvipy commented Oct 20, 2022

awesome. thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery Import Error
2 participants