Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde DKG for BLS12-377 #12

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Serde DKG for BLS12-377 #12

merged 6 commits into from
Apr 15, 2020

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented Apr 15, 2020

Supersedes on #6. It fixes the merge conflicts and utilizes serde's serialize_with and deserialize_with to implement it for our wrapper structs cleanly.

@gakonst
Copy link
Contributor Author

gakonst commented Apr 15, 2020

Let's wait on an answer for serde-rs/serde#1778 before merging

@gakonst
Copy link
Contributor Author

gakonst commented Apr 15, 2020

We can safely opt-out of the atomic feature since we only use BitVec:

BitBox and BitVec are theoretically thread-safe regardless of this feature, as the borrow checker’s rules combine with the allocator regime to forbid shared-mutation faults with these types. However, as a conservative rule and to maintain consistency, these types also remove their thread-safety markers when atomic is disabled.

https://github.com/myrrlyn/bitvec#atomic

@gakonst gakonst merged commit 078f1f4 into master Apr 15, 2020
@gakonst gakonst deleted the gakonst/serde-dkg branch April 15, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants