Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Comment on GRPC latency measure reuse (#1214) #1217

Merged
merged 1 commit into from Jul 5, 2020
Merged

Comment on GRPC latency measure reuse (#1214) #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugin/ocgrpc/client_metrics.go
View file
Open in desktop
Expand Up @@ -60,6 +60,8 @@ var (
Aggregation: DefaultMillisecondsDistribution,
}

// Purposely reuses the count from `ClientRoundtripLatency`, tagging
// with method and status to result in ClientCompletedRpcs.
ClientCompletedRPCsView = &view.View{
Measure: ClientRoundtripLatency,
Name: "grpc.io/client/completed_rpcs",
Expand Down
2 changes: 2 additions & 0 deletions plugin/ocgrpc/server_metrics.go
View file
Open in desktop
Expand Up @@ -63,6 +63,8 @@ var (
Aggregation: DefaultMillisecondsDistribution,
}

// Purposely reuses the count from `ServerLatency`, tagging
// with method and status to result in ServerCompletedRpcs.
ServerCompletedRPCsView = &view.View{
Name: "grpc.io/server/completed_rpcs",
Description: "Count of RPCs by method and status.",
Expand Down