Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Commit

Permalink
Fix retry stat measures to match those in grpc-java exactly (#2097) (#…
Browse files Browse the repository at this point in the history
…2102)

* update descriptions of retry measures to match those in grpc-java exactly
* change GRPC_CLIENT_RETRY_DELAY_PER_CALL from MeasureLong to MeasureDouble

Co-authored-by: Mackenzie Starr <mstarr@etsy.com>
  • Loading branch information
punya and mackenziestarr committed Apr 5, 2022
1 parent d24539e commit 602b56c
Showing 1 changed file with 5 additions and 7 deletions.
Expand Up @@ -235,7 +235,7 @@ public final class RpcMeasureConstants {
*/
public static final MeasureLong GRPC_CLIENT_RETRIES_PER_CALL =
Measure.MeasureLong.create(
"grpc.io/client/retries_per_call", "Number of retries per call.", COUNT);
"grpc.io/client/retries_per_call", "Number of retries per call", COUNT);

/**
* {@link Measure} for total number of transparent retries made during the client call.
Expand All @@ -244,19 +244,17 @@ public final class RpcMeasureConstants {
*/
public static final MeasureLong GRPC_CLIENT_TRANSPARENT_RETRIES_PER_CALL =
Measure.MeasureLong.create(
"grpc.io/client/transparent_retries_per_call",
"Number of transparent retries per call.",
COUNT);
"grpc.io/client/transparent_retries_per_call", "Transparent retries per call", COUNT);

/**
* {@link Measure} for total time of delay while there is no active attempt during the client
* call.
*
* @since 0.28
*/
public static final MeasureLong GRPC_CLIENT_RETRY_DELAY_PER_CALL =
Measure.MeasureLong.create(
"grpc.io/client/retry_delay_per_call", "Retry delay per call.", MILLISECOND);
public static final MeasureDouble GRPC_CLIENT_RETRY_DELAY_PER_CALL =
Measure.MeasureDouble.create(
"grpc.io/client/retry_delay_per_call", "Retry delay per call", MILLISECOND);

/**
* {@link Measure} for gRPC client error counts.
Expand Down

0 comments on commit 602b56c

Please sign in to comment.