Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Commit

Permalink
Merge pull request #75 from dinooliva/rpc-constants
Browse files Browse the repository at this point in the history 
Updates RpcConstants to have appropriate ViewDescriptors.
  • Loading branch information
@dinooliva
dinooliva committed Dec 15, 2016
2 parents 570c861 + f1c31e2 commit cda08dd
Showing 1 changed file with 140 additions and 27 deletions.
167 changes: 140 additions & 27 deletions core/java/com/google/instrumentation/stats/RpcConstants.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,26 @@

import com.google.instrumentation.stats.MeasurementDescriptor.BasicUnit;
import com.google.instrumentation.stats.MeasurementDescriptor.MeasurementUnit;
import com.google.instrumentation.stats.ViewDescriptor.DistributionViewDescriptor;

import java.util.Arrays;
import java.util.List;

/**
* Census constants for collecting rpc stats.
* Constants for collecting rpc stats.
*/
public final class RpcConstants {
/**
* Census defined tag keys.
* Rpc tag keys.
*/
public static final TagKey RPC_STATUS = TagKey.create("/rpc/status");
public static final TagKey RPC_CLIENT_METHOD = TagKey.create("/rpc/client_method");
public static final TagKey RPC_SERVER_METHOD = TagKey.create("/rpc/server_method");
public static final TagKey RPC_STATUS = TagKey.create("OpStatus");
public static final TagKey RPC_CLIENT_METHOD = TagKey.create("method");
public static final TagKey RPC_SERVER_METHOD = TagKey.create("method");

// Constants used to define the following MeasurementDescriptors.
private static final List<BasicUnit> bytes = Arrays.asList(new BasicUnit[] { BasicUnit.BYTES });
private static final List<BasicUnit> scalar = Arrays.asList(new BasicUnit[] { BasicUnit.SCALAR });
private static final List<BasicUnit> seconds =
Arrays.asList(new BasicUnit[] { BasicUnit.SECONDS });
private static final List<BasicUnit> bytes = Arrays.asList(BasicUnit.BYTES);
private static final List<BasicUnit> scalar = Arrays.asList(BasicUnit.SCALAR);
private static final List<BasicUnit> seconds = Arrays.asList(BasicUnit.SECONDS);

/**
* Census defined rpc client {@link MeasurementDescriptor}s.
Expand All @@ -47,29 +47,34 @@ public final class RpcConstants {
public static final MeasurementDescriptor RPC_CLIENT_REQUEST_BYTES =
MeasurementDescriptor.create(
"/rpc/client/request_bytes",
"Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Request MB",
MeasurementUnit.create(6, bytes));
public static final MeasurementDescriptor RPC_CLIENT_RESPONSE_BYTES =
MeasurementDescriptor.create(
"/rpc/client/response_bytes",
"Response MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Response MB",
MeasurementUnit.create(6, bytes));
// TODO(dpo): verify this encoding
public static final MeasurementDescriptor RPC_CLIENT_ROUNDTRIP_LATENCY =
MeasurementDescriptor.create(
"/rpc/client/roundtrip_latency",
"RPC roundtrip latency us",
MeasurementUnit.create(-6, scalar));
MeasurementUnit.create(-6, seconds));
public static final MeasurementDescriptor RPC_CLIENT_SERVER_ELAPSED_TIME =
MeasurementDescriptor.create(
"/rpc/client/server_elapsed_time",
"Server elapsed time in msecs",
MeasurementUnit.create(-3, seconds));
public static final MeasurementDescriptor RPC_CLIENT_UNCOMPRESSED_REQUEST_BYTES =
MeasurementDescriptor.create(
"/rpc/client/uncompressed_request_bytes",
"Uncompressed Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Uncompressed Request MB",
MeasurementUnit.create(6, bytes));
public static final MeasurementDescriptor RPC_CLIENT_UNCOMPRESSED_RESPONSE_BYTES =
MeasurementDescriptor.create(
"/rpc/client/uncompressed_response_bytes",
"Uncompressed Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Uncompressed Request MB",
MeasurementUnit.create(6, bytes));

/**
* Census defined rpc server {@link MeasurementDescriptor}s.
Expand All @@ -82,28 +87,136 @@ public final class RpcConstants {
public static final MeasurementDescriptor RPC_SERVER_REQUEST_BYTES =
MeasurementDescriptor.create(
"/rpc/server/request_bytes",
"Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Request MB",
MeasurementUnit.create(6, bytes));
public static final MeasurementDescriptor RPC_SERVER_RESPONSE_BYTES =
MeasurementDescriptor.create(
"/rpc/server/response_bytes",
"Response MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Response MB",
MeasurementUnit.create(6, bytes));
public static final MeasurementDescriptor RPC_SERVER_SERVER_ELAPSED_TIME =
MeasurementDescriptor.create(
"/rpc/server/server_elapsed_time",
"Server elapsed time in msecs",
MeasurementUnit.create(-3, seconds));
public static final MeasurementDescriptor RPC_SERVER_SERVER_LATENCY =
MeasurementDescriptor.create(
"/rpc/server/server_latency",
"Latency in msecs",
MeasurementUnit.create(-3, scalar));
MeasurementUnit.create(-3, seconds));
public static final MeasurementDescriptor RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES =
MeasurementDescriptor.create(
"/rpc/server/uncompressed_request_bytes",
"Uncompressed Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Uncompressed Request MB",
MeasurementUnit.create(6, bytes));
public static final MeasurementDescriptor RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES =
MeasurementDescriptor.create(
"/rpc/server/uncompressed_response_bytes",
"Uncompressed Request MB/s",
MeasurementUnit.create(6, bytes, seconds));
"Uncompressed Request MB",
MeasurementUnit.create(6, bytes));

// Common histogram bucket boundaries for bytes received/sets DistributionViewDescriptors.
private static final List<Double> RPC_BYTES_BUCKET_BOUNDARIES = Arrays.asList(
0.0, 1024.0, 2048.0, 4096.0, 16384.0, 65536.0, 262144.0, 1048576.0, 4194304.0, 16777216.0,
67108864.0, 268435456.0, 1073741824.0, 4294967296.0);

// Common histogram bucket boundaries for latency and elapsed-time DistributionViewDescriptors.
private static final List<Double> RPC_MILLIS_BUCKET_BOUNDARIES = Arrays.asList(
0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 8.0, 10.0, 13.0, 16.0, 20.0, 25.0, 30.0, 40.0, 50.0,
65.0, 80.0, 100.0, 130.0, 160.0, 200.0, 250.0, 300.0, 400.0, 500.0, 650.0, 800.0, 1000.0,
2000.0, 5000.0, 10000.0, 20000.0, 50000.0, 100000.0);

/**
* Census defined rpc client {@link ViewDescriptor}s.
*/
public static final DistributionViewDescriptor RPC_CLIENT_ERROR_COUNT_VIEW =
DistributionViewDescriptor.create(
"rpc client error count",
"RPC Errors",
RPC_CLIENT_ERROR_COUNT,
DistributionAggregationDescriptor.create(),
Arrays.asList(RPC_STATUS, RPC_CLIENT_METHOD));
public static final DistributionViewDescriptor RPC_CLIENT_ROUNDTRIP_LATENCY_VIEW =
DistributionViewDescriptor.create(
"rpc client roundtrip latency",
"Latency in msecs",
RPC_CLIENT_ROUNDTRIP_LATENCY,
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
Arrays.asList(RPC_CLIENT_METHOD));
public static final DistributionViewDescriptor RPC_CLIENT_SERVER_ELAPSED_TIME_VIEW =
DistributionViewDescriptor.create(
"rpc client server_elapsed_time",
"Server elapsed time in msecs",
RPC_CLIENT_SERVER_ELAPSED_TIME,
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
Arrays.asList(RPC_CLIENT_METHOD));
public static final DistributionViewDescriptor RPC_CLIENT_REQUEST_BYTES_VIEW =
DistributionViewDescriptor.create(
"rpc client request_bytes",
"Request MB",
RPC_CLIENT_REQUEST_BYTES,
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
Arrays.asList(RPC_CLIENT_METHOD));
public static final DistributionViewDescriptor RPC_CLIENT_RESPONSE_BYTES_VIEW =
DistributionViewDescriptor.create(
"/rpc/client/response_bytes",
"Response MB",
RPC_CLIENT_RESPONSE_BYTES,
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
Arrays.asList(RPC_CLIENT_METHOD));

/**
* Census defined rpc server {@link ViewDescriptor}s.
*/
public static final DistributionViewDescriptor RPC_SERVER_ERROR_COUNT_VIEW =
DistributionViewDescriptor.create(
"rpc server error count",
"RPC Errors",
RPC_SERVER_ERROR_COUNT,
DistributionAggregationDescriptor.create(),
Arrays.asList(RPC_STATUS, RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_SERVER_LATENCY_VIEW =
DistributionViewDescriptor.create(
"rpc server latency",
"Latency in msecs",
RPC_SERVER_SERVER_LATENCY,
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
Arrays.asList(RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_SERVER_ELAPSED_TIME_VIEW =
DistributionViewDescriptor.create(
"rpc server elapsed_time",
"Server elapsed time in msecs",
RPC_SERVER_SERVER_ELAPSED_TIME,
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
Arrays.asList(RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_REQUEST_BYTES_VIEW =
DistributionViewDescriptor.create(
"rpc server request_bytes",
"Request MB",
RPC_SERVER_REQUEST_BYTES,
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
Arrays.asList(RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_RESPONSE_BYTES_VIEW =
DistributionViewDescriptor.create(
"/rpc/server/response_bytes",
"Response MB",
RPC_SERVER_RESPONSE_BYTES,
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
Arrays.asList(RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES_VIEW =
DistributionViewDescriptor.create(
"/rpc/server/uncompressed_request_bytes",
"Uncompressed Request MB",
RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES,
DistributionAggregationDescriptor.create(),
Arrays.asList(RPC_SERVER_METHOD));
public static final DistributionViewDescriptor RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES_VIEW =
DistributionViewDescriptor.create(
"/rpc/server/uncompressed_response_bytes",
"Uncompressed Request MB",
RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES,
DistributionAggregationDescriptor.create(),
Arrays.asList(RPC_SERVER_METHOD));

// Visible for testing
RpcConstants() {
Expand Down

0 comments on commit cda08dd

Please sign in to comment.