This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Avoid using finalizers when not leaking open spans #2046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkrka
requested review from
dinooliva,
rghetia,
songy23 and
a team
as code owners
spkrka
force-pushed
the
krka/avoid_finalizer_in_stable_state
branch
from
09ff2dc
to
2842327
Compare
|
See #2045 |
spkrka
force-pushed
the
krka/avoid_finalizer_in_stable_state
branch
3 times, most recently
from
a4db990
to
b987540
Compare
spkrka
force-pushed
the
krka/avoid_finalizer_in_stable_state
branch
from
b987540
to
e895e60
Compare
|
As described in #2045 (comment), I suggest to revisit #2043 and merge it instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.