This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
fix: Shutdown Stackdriver MetricServiceClient properly #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the default configuration of StackdriverStatsConfiguration, a MetricServiceClient is initialized by the StackdriverStatsExporter. This client was never closed, this will be done now when the .unregister() method is called on the exporter. If a custom MetricServiceStub is given by the user, it will *not* be closed as the user should be in charge of it.
punya
reviewed
Jan 12, 2022
...kdriver/src/main/java/io/opencensus/exporter/stats/stackdriver/StackdriverStatsExporter.java
Show resolved
Hide resolved
punya
approved these changes
Jan 13, 2022
gcf-merge-on-green bot
pushed a commit
to googleapis/java-spanner
that referenced
this pull request
Feb 2, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.opencensus:opencensus-contrib-grpc-metrics](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-exporter-stats-stackdriver](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-exporter-trace-stackdriver](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-contrib-zpages](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-impl](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-api](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-contrib-grpc-util](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>census-instrumentation/opencensus-java</summary> ### [`v0.31.0`](https://togithub.com/census-instrumentation/opencensus-java/releases/v0.31.0) [Compare Source](https://togithub.com/census-instrumentation/opencensus-java/compare/v0.30.0...v0.31.0) - fix: Shutdown Stackdriver MetricServiceClient properly by [@​janhicken](https://togithub.com/janhicken) in [census-instrumentation/opencensus-java#2091 - implement gRPC client retry stats measures and views by [@​mackenziestarr](https://togithub.com/mackenziestarr) in [census-instrumentation/opencensus-java#2084 **Full Changelog**: census-instrumentation/opencensus-java@v0.29.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner).
](https://renovatebot.com){kind=link}
gcf-merge-on-green bot
pushed a commit
to googleapis/google-http-java-client
that referenced
this pull request
Feb 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.opencensus:opencensus-testing](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-impl](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-contrib-http-util](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.opencensus:opencensus-api](https://togithub.com/census-instrumentation/opencensus-java) | `0.30.0` -> `0.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>census-instrumentation/opencensus-java</summary> ### [`v0.31.0`](https://togithub.com/census-instrumentation/opencensus-java/releases/v0.31.0) [Compare Source](https://togithub.com/census-instrumentation/opencensus-java/compare/v0.30.0...v0.31.0) - fix: Shutdown Stackdriver MetricServiceClient properly by [@​janhicken](https://togithub.com/janhicken) in [census-instrumentation/opencensus-java#2091 - implement gRPC client retry stats measures and views by [@​mackenziestarr](https://togithub.com/mackenziestarr) in [census-instrumentation/opencensus-java#2084 **Full Changelog**: census-instrumentation/opencensus-java@v0.29.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-http-java-client).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default configuration of
StackdriverStatsConfiguration, aMetricServiceClientis initialized by theStackdriverStatsExporter.This client was never closed, this will be done now when the
StackdriverStatsExporter.unregister()method is called.If a custom
MetricServiceStubis given by the user, it will not be closed as the user should be in charge of it.This should fix #2007.