This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
test: remove check for specific byte size in gRPC tests #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is prone to flaking with upgrades of `object-sizeof` package as well as being different across different versions of node. I think simply checking that the size was not zero is sufficient and avoids making the test too specific.
aabmass
requested review from
punya,
damemi and
psx95
and removed request for
draffensperger and
mayurkale22
punya
approved these changes
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: remove check for specific byte size in gRPC tests
This check is prone to flaking with upgrades of
object-sizeofpackage as well as being different across different versions of node. I think simply checking that the size was not zero is sufficient and avoids making the test too specific.