Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix circular import #647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix circular import #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/opencensus-instrumentation-http2/src/http2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
SpanKind,
TraceOptions,
} from '@opencensus/core';
import 'http';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment for why this line is needed to avoid the circular import? And similar for the other case below?

import { HttpPlugin } from '@opencensus/instrumentation-http';
import * as http2 from 'http2';
import * as shimmer from 'shimmer';
Expand Down
1 change: 1 addition & 0 deletions packages/opencensus-instrumentation-https/src/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

import { Func } from '@opencensus/core';
import 'http';
import { HttpPlugin } from '@opencensus/instrumentation-http';
import * as http from 'http';
import * as https from 'https';
Expand Down