This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
enh(ui): search resources when pressing enter key #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thebarda
previously approved these changes
Mar 30, 2020
kduret
commented
Mar 30, 2020
| @@ -5,6 +5,7 @@ import formatISO from 'date-fns/formatISO'; | |||
| import { render, waitFor, within, fireEvent } from '@testing-library/react'; | |||
| import UserEvent from '@testing-library/user-event'; | |||
| import last from 'lodash/last'; | |||
| import { Simulate } from 'react-dom/test-utils'; | |||
There was a problem hiding this comment.
user-event currently does not manage special keys.
Waiting this PR : testing-library/user-event#235
bdauria
approved these changes
Mar 31, 2020
jdelpierre
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search resources when search field is focused and enter is pressed
Fixes MON-5095
Type of change
Target serie
How this pull request can be tested ?
Type search in search field and press enter
==> check search is applied, without need of clicking on search button