Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ramen-dr job #2138

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add ramen-dr job #2138

wants to merge 1 commit into from

Conversation

rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Jun 7, 2023

This is an initial attempt to run ramendr/ramen e2e tests which should trigger for every PR.
This PR will only run unit tests for now.
Ramen Repo: https://github.com/RamenDR/ramen.git

@rakeshgm rakeshgm requested a review from dmick June 7, 2023 09:08
artifact-days-to-keep: -1
artifact-num-to-keep: -1
- github:
url: https://github.com/rakeshgm/ramen/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added my fork for testing purposes


scm:
- git:
url: https://github.com/rakeshgm/ramen.git
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added my fork for testing purposes

@rakeshgm rakeshgm marked this pull request as draft June 7, 2023 09:11
export PATH=$PATH:/usr/local/go/bin

# install make
sudo yum install make -y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this need to be sudo yum install -y make ?

@dmick
Copy link
Member

dmick commented Jun 7, 2023

Good start. You'll need to clean up anything you install, too. A few notes:

  • is installing go from a tarball really the right way to install go? Are there not distro packages?

  • if you make the git repo a variable, you can give a default of your workspace for now, and then just change it when you're ready with the job

  • have you tested build/build on a clean installed image (container or vm, maybe)?

@rakeshgm
Copy link
Member Author

rakeshgm commented Jun 8, 2023

so installation from Tarball is what the official document says. doc.
I will make the remaining changes and yes, I have now tested the script on a vm

@rakeshgm rakeshgm force-pushed the ramen-pr branch 2 times, most recently from 4580e8f to 0fcb693 Compare June 9, 2023 13:02
this is the initial change which will run only
unit tests.

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What triggers this build?

@rakeshgm
Copy link
Member Author

What triggers this build?

mostly pull-requests to the repo.

Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the branch locally and tested pushing it to the server. Noticed a few minor things:

  1. name the file .yml like all the others (rather than .yaml)
  2. Title the pull request "Add ramen-pull-requests" (which is the name of the actual job)
  3. change the commit message to describe what the job does and for what purpose; the fact that it's the initial change is obvious from the git history, so note what ramen is and what role it serves in ceph

@dmick
Copy link
Member

dmick commented Jun 21, 2023

I pushed the job to the jenkins server by hand. It failed because it ran on a non-dnf system; you'll need to add labels to select the right sort of build host. I suspect you want something like either 'centos8' or 'centos9'. Also, I doubt it needs to be "huge". Does/will this need testing on both x86_64 and arm64?

Here's the build log: https://jenkins.ceph.com/job/ramen-pull-requests/1/consoleFull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants