-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ramen-dr job #2138
base: main
Are you sure you want to change the base?
Add ramen-dr job #2138
Conversation
artifact-days-to-keep: -1 | ||
artifact-num-to-keep: -1 | ||
- github: | ||
url: https://github.com/rakeshgm/ramen/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added my fork for testing purposes
|
||
scm: | ||
- git: | ||
url: https://github.com/rakeshgm/ramen.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added my fork for testing purposes
ramen-pull-requests/build/build
Outdated
export PATH=$PATH:/usr/local/go/bin | ||
|
||
# install make | ||
sudo yum install make -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't this need to be sudo yum install -y make ?
Good start. You'll need to clean up anything you install, too. A few notes:
|
so installation from Tarball is what the official document says. doc. |
4580e8f
to
0fcb693
Compare
this is the initial change which will run only unit tests. Signed-off-by: rakeshgm <rakeshgm@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What triggers this build?
mostly pull-requests to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the branch locally and tested pushing it to the server. Noticed a few minor things:
- name the file .yml like all the others (rather than .yaml)
- Title the pull request "Add ramen-pull-requests" (which is the name of the actual job)
- change the commit message to describe what the job does and for what purpose; the fact that it's the initial change is obvious from the git history, so note what ramen is and what role it serves in ceph
I pushed the job to the jenkins server by hand. It failed because it ran on a non-dnf system; you'll need to add labels to select the right sort of build host. I suspect you want something like either 'centos8' or 'centos9'. Also, I doubt it needs to be "huge". Does/will this need testing on both x86_64 and arm64? Here's the build log: https://jenkins.ceph.com/job/ramen-pull-requests/1/consoleFull |
This is an initial attempt to run ramendr/ramen e2e tests which should trigger for every PR.
This PR will only run unit tests for now.
Ramen Repo: https://github.com/RamenDR/ramen.git