Wip leonidc 20240418 map validation #127
Open
+203,681
−55,261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mulligan <jmulligan@redhat.com>
tox supports automatically running tools with different python versions if you name your envs properly. Continue to permit the use of `mypy` as an env (as the default) but also allow a selection of python versions like `py38-mypy`. Signed-off-by: John Mulligan <jmulligan@redhat.com>
In the tox.ini file the modules validated by mypy are explicitly listed. Fix one item which was indented differently than the others. Sort the list. Signed-off-by: John Mulligan <jmulligan@redhat.com>
…diting cephadm: sudo cmd auditing Reviewed-by: Adam King <adking@redhat.com>
crimson: add crimson-osd rpm and deb runtime dependencies for protobuf inherited from seastar
seastar::repeat may or may not move the passed action after the first invocation, so we can't actually rely on references to variables captured by value being stable. Instead, allocate with std::make_unique and move into a finally lambda. Fixes: https://tracker.ceph.com/issues/64996 Signed-off-by: Samuel Just <sjust@redhat.com>
test/encoding/check-generated: parallel testing by type
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: molpako <35787116+molpako@users.noreply.github.com>
qa/suite/rbd/nvmeof: Deploy multiple gateways and namespaces Reviewed-by: Barak Davidov <barakda@il.ibm.com> Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com> Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Fixes: https://tracker.ceph.com/issues/64911 Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Fixes: https://tracker.ceph.com/issues/62350 Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
When sending a "queued reservation" request (the new default), the OSD will not respond until the reservation is granted. This can take a long time, and the client should not be warned about a "slow response". Fixes: https://tracker.ceph.com/issues/64869 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Fix snap schedule list monthly retention frequency display Fixes: https://tracker.ceph.com/issues/64982 Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
doc/cephfs: fix architecture link to correct relative path Reviewed-by: Zac Dover <zac.dover@proton.me>
rgw/notification: Make the LifeCycle & Replication events AWS Compatible and Support s3:Replication:Delete event Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com> Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
RGW: allow user disabling presigned urls in rgw configuration Reviewed-by: Casey Bodley <cbodley@redhat.com>
rgw: Add missing empty checks to the split string in is_string_in_set(). Reviewed-by: Casey Bodley <cbodley@redhat.com>
rgw_file: fix mv/rename cases broken by zipper integration Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
qa/rgw: ignore POOL_APP_NOT_ENABLED in rgw/lua subsuite Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
To stream JSON to a file for collection (for testing). The idea here that trying to send a very large JSON result over `ceph tell` is best to be avoided. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
A quiesce op in the MDS may run for an indeterminate amount of time. Warnings should not be generated. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
From a past commit. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
- gw subsystems update propose state change when subsystems reported by the gateway changes. otherwise, only the initially reported subsystem is handled, and any new subsystem listener ana groups could remain "unreachable". example of the bug: https://github.com/ceph/ceph-nvmeof/actions/runs/8603572675/job/23576286745?pr=560 Signed-off-by: Alexander Indenbaum <aindenba@redhat.com> (cherry picked from commit 7ad25a3) - fixing issue : same group set to Active on 2 gws Signed-off-by: Leonid Chernin <leonidc@il.ibm.com> (cherry picked from commit f2d3d29) Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
leonidc
requested review from
afreen23 and
aaSharma14
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows