Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: add generic ephemeral volume validation #2603

Merged
merged 3 commits into from Nov 22, 2021
Merged

rbd: add generic ephemeral volume validation #2603

merged 3 commits into from Nov 22, 2021

Conversation

humblec
Copy link
Collaborator

@humblec humblec commented Oct 28, 2021 •
edited 

rbd: add generic ephemeral volume validation

This commit adds the validation of csi RBD driver to work with
ephemeral volume support. With ephemeral volume support a user can
specify ephemeral volumes in its pod spec and tie the lifecycle
of the PVC with the POD.

An example POD spec looks like this:

kind: Pod
apiVersion: v1
metadata:
  name: my-app
   spec:
  containers:
    - name: csi-rbd-demo-pod
      image: busybox
      volumeMounts:
        - mountPath: "/scratch"
          name: mypvc
      command: [ "sleep", "1000000" ]
  volumes:
    - name: mypvc
      ephemeral:
        volumeClaimTemplate:
          spec:
            accessModes: [ "ReadWriteOnce" ]
            storageClassName: "csi-rbd-sc"
            resources:
              requests:
                storage: 1Gi

Additional Ref # rook/rook#9055

Updates #2587

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@mergify mergify bot added the component/rbd Issues related to RBD label Oct 28, 2021
@nixpanic nixpanic added the component/testing Additional test cases or CI work label Oct 28, 2021
@humblec humblec changed the title [WIP] rbd: add generic ephemeral volume validation rbd: add generic ephemeral volume validation Oct 29, 2021
@humblec humblec mentioned this pull request Oct 29, 2021
Merged
10 tasks
Madhu-1
Madhu-1 previously requested changes Oct 29, 2021
View reviewed changes
e2e/rbd.go Outdated Show resolved Hide resolved
e2e/rbd.go Show resolved Hide resolved
examples/rbd/pod-ephemeral.yaml Outdated Show resolved Hide resolved
e2e/rbd.go Outdated Show resolved Hide resolved
e2e/rbd.go Show resolved Hide resolved
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 29, 2021

please add same e2e for cephfs also

@humblec humblec force-pushed the generic-ephemeral-volumes branch 9 times, most recently from 5310e9b to 03e8e35 Compare October 29, 2021 09:19
@humblec
Copy link
Collaborator Author

humblec commented Oct 29, 2021

@Madhu-1 added tests for cephfs too and enabled feature gate only for kube versions >=1.20. PTAL.

@humblec humblec requested a review from Madhu-1 October 29, 2021 09:20
@humblec humblec dismissed Madhu-1’s stale review October 29, 2021 09:20

ptal comments are addressed

@humblec humblec requested a review from a team October 29, 2021 10:13
nixpanic
nixpanic requested changes Nov 1, 2021
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is simpler to included the example .yaml files with the e2e commits so that they are self contained and really belong together. There is then no need to include the full yaml in the commit message anymore, cleaning things up a little.

scripts/minikube.sh Outdated Show resolved Hide resolved
scripts/minikube.sh Outdated Show resolved Hide resolved
@humblec humblec force-pushed the generic-ephemeral-volumes branch 2 times, most recently from 6596b0b to da3f846 Compare November 2, 2021 05:10
@humblec
Copy link
Collaborator Author

humblec commented Nov 2, 2021

It is simpler to included the example .yaml files with the e2e commits so that they are self contained and really belong together. There is then no need to include the full yaml in the commit message anymore, cleaning things up a little.

sure, squashed commits of example yaml to the validation commit.

nixpanic
nixpanic previously requested changes Nov 2, 2021
View reviewed changes
scripts/minikube.sh Outdated Show resolved Hide resolved
scripts/minikube.sh Show resolved Hide resolved
@github-actions
Copy link

@humblec "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@github-actions
Copy link

/retest ci/centos/mini-e2e/k8s-1.22

@github-actions
Copy link

@humblec "ci/centos/mini-e2e/k8s-1.22" test failed. Logs are available at location for debugging

@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2021

rebase

✅ Branch has been successfully rebased

@github-actions
Copy link

/retest ci/centos/mini-e2e/k8s-1.21

@github-actions
Copy link

@humblec "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@github-actions
Copy link

/retest ci/centos/mini-e2e-helm/k8s-1.22

@github-actions
Copy link

@humblec "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@humblec
Copy link
Collaborator Author

humblec commented Nov 19, 2021

/retest ci/centos/mini-e2e-helm/k8s-1.21

@github-actions
Copy link

/retest ci/centos/mini-e2e/k8s-1.21

@github-actions
Copy link

@humblec "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@github-actions
Copy link

/retest ci/centos/mini-e2e-helm/k8s-1.22

@github-actions
Copy link

@humblec "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@humblec
Copy link
Collaborator Author

humblec commented Nov 19, 2021

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2021

rebase

✅ Branch has been successfully rebased

@humblec
Copy link
Collaborator Author

humblec commented Nov 22, 2021

@Mergifyio rebase

@humblec
Copy link
Collaborator Author

humblec commented Nov 22, 2021

/retest ci/centos/mini-e2e-helm/k8s-1.21

@humblec
rbd: add generic ephemeral volume validation
e7658ea 
This commit adds the validation of csi RBD driver to work with
ephemeral volume support. With ephemeral volume support a user can
specify ephemeral volumes in its pod spec and tie the lifecycle
of the PVC with the POD.

An example pod spec is also included in this commit.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
cephfs: add validation for generic ephemeral volumes
60b20b9 
This commit adds the validation of csi cephfs driver to work with
ephemeral volume support. With ephemeral volume support a user can
specify ephemeral volumes in its pod spec and tie the lifecycle
of the PVC with the POD.

An example POD spec also included in this commit.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
deploy: remove expandCSIVolumes feature gate from deployment
ed778e3 
The `expandCSIVolumes` feature gate is beta since kubernetes 1.16
version and we no longer wanted to explictly enable it in the
deployment.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

rebase

✅ Branch has been successfully rebased

@github-actions
Copy link

/retest ci/centos/mini-e2e/k8s-1.20

@github-actions
Copy link

@humblec "ci/centos/mini-e2e/k8s-1.20" test failed. Logs are available at location for debugging

@github-actions
Copy link

/retest ci/centos/mini-e2e/k8s-1.20

@github-actions
Copy link

@humblec "ci/centos/mini-e2e/k8s-1.20" test failed. Logs are available at location for debugging

@mergify mergify bot merged commit aa60075 into ceph:devel Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Yuggupta27 Yuggupta27 Awaiting requested review from Yuggupta27

@yati1998 yati1998 Awaiting requested review from yati1998

@nixpanic nixpanic Awaiting requested review from nixpanic

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/cephfs Issues related to CephFS component/rbd Issues related to RBD component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@humblec @Madhu-1 @nixpanic @Rakshith-R