Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: use leases for leader election #3011

Merged
merged 1 commit into from Apr 14, 2022
Merged

rbd: use leases for leader election #3011

merged 1 commit into from Apr 14, 2022

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Apr 11, 2022

use leases for leader election instead of the deprecated configmap based leader election.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

@mergify mergify bot added the component/rbd Issues related to RBD label Apr 11, 2022
humblec
humblec previously approved these changes Apr 11, 2022
View reviewed changes
@Madhu-1 Madhu-1 requested a review from a team April 11, 2022 08:13
@Madhu-1 Madhu-1 added this to the release-3.6.1 milestone Apr 11, 2022
yati1998
yati1998 previously approved these changes Apr 11, 2022
View reviewed changes
nixpanic
nixpanic requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the deprecation notice?

This now imports a Kubernetes package, making the CSi-driver more dependent on that single CO. Not sure this is the preferred solution.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Apr 11, 2022

Could you link to the deprecation notice?

This PR is making leases as default leader election kubernetes-sigs/controller-runtime#1773, default from configmap to configmap leases was done with kubernetes-sigs/controller-runtime#1144 https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.7.0

All the kubernetes sidecars are based on the leases based leader election, configmap is deprecated long back.

This now imports a Kubernetes package, making the CSi-driver more dependent on that single CO. Not sure this is the preferred solution.

The whole controller is written using the controller runtime it's only meant for kubernetes and it exists for a long time. This PR is just changing the leader type.

@mergify mergify bot dismissed stale reviews from humblec and yati1998 April 11, 2022 09:03

Pull request has been modified.

@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Apr 13, 2022
@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@Madhu-1
rbd: use leases for leader election
823cbfc 
use leases for leader election instead
of the deprecated configmap based leader
election.

This PR is making leases as default leader election
refer https://github.com/kubernetes-sigs/
controller-runtime/pull/1773, default from configmap
to configmap leases was done with
https://github.com/kubernetes-sigs/
controller-runtime/pull/1144.

Release notes https://github.com/kubernetes-sigs/
controller-runtime/releases/tag/v0.7.0

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.23

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.23" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/upgrade-tests-rbd" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.23

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.23" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

refresh

✅ Pull request refreshed

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Apr 14, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2022

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit d886ab0 into ceph:devel Apr 14, 2022
@mergify mergify bot mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@humblec humblec humblec approved these changes

@yati1998 yati1998 Awaiting requested review from yati1998

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/rbd Issues related to RBD
Projects
None yet
Milestone
release-3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Madhu-1 @ceph-csi-bot @nixpanic @humblec @yati1998