Merge pull request #92 from GowthamShanmugam/1970354

Handle empty ceph_version in ceph_mon_metadata to avoid raising misleading alert
ceph · Feb 2, 2022 · 7ddbd7a · 7ddbd7a
2 parents c77ec28 + a5fa42d
commit 7ddbd7a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/alerts/state.libsonnet b/alerts/state.libsonnet
@@ -55,7 +55,7 @@
           {
             alert: 'CephMonVersionMismatch',
             expr: |||
-              count(count(ceph_mon_metadata{%(cephExporterSelector)s}) by (ceph_version)) > 1
+              count(count(ceph_mon_metadata{%(cephExporterSelector)s, ceph_version != ""}) by (ceph_version)) > 1
             ||| % $._config,
             'for': $._config.clusterVersionAlertTime,
             labels: {

diff --git a/extras/manifests/prometheus-ceph-rules.yaml b/extras/manifests/prometheus-ceph-rules.yaml
@@ -263,7 +263,7 @@ spec:
         severity_level: warning
         storage_type: ceph
       expr: |
-        count(count(ceph_mon_metadata{job="rook-ceph-mgr"}) by (ceph_version)) > 1
+        count(count(ceph_mon_metadata{job="rook-ceph-mgr", ceph_version != ""}) by (ceph_version)) > 1
       for: 10m
       labels:
         severity: warning