ceph: improve building of dev images #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set `NVMEOF_GW` for `vstart` to work with nvmeof. - Help debug ceph.repo issues. - Add new `CEPH_CLUSTER_CEPH_REPO_BASEURL` alternative to setting `CEPH_BRANCH` and `CEPH_SHA`. - Fix setting `CEPH_CLUSTER_CEPH_REPO_BASEURL` in `Makefile` not to override value if externally set (via .env). Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
epuertat
force-pushed
the
wip-ceph_build-devel
branch
from
7c3dc0c
to
742bba9
Compare
baum
reviewed
Mar 20, 2024
|
BTW, @baum this change broke support for |
@epuertat |
baum
reviewed
Mar 21, 2024
| labels: | ||
| io.ceph.nvmeof: | ||
| environment: | ||
| TOUCHFILE: /tmp/ceph.touch | ||
| NVMEOF_GW: ${NVMEOF_IP_ADDRESS}:${NVMEOF_GW_PORT} |
There was a problem hiding this comment.
How is the NVMEOF_GW variable utilized? And what occurs in a multi-gateway deployment?
baum
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMEOF_GWforvstartto work with nvmeof.CEPH_CLUSTER_CEPH_REPO_BASEURLalternative to settingCEPH_BRANCHandCEPH_SHA.CEPH_CLUSTER_CEPH_REPO_BASEURLinMakefilenot to override value if externally set (via .env).