Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Concurrency in Gateway Operations #600

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

baum
Copy link
Collaborator

@baum baum commented Apr 18, 2024

Improved Concurrency in Gateway Operations

Enhances gateway concurrency by enabling simultaneous processing of requests. Addresses the risk of the monitor erroneously considering the gateway as "not available" due to blocked get_subsystem() service by an operation acquiring the omap lock.

  • Released RPC lock during sleeping in the OMAP lock procedure.
  • Allows multiple worker threads to execute concurrently in the gRPC executor.

Copy link
Contributor

@gbregman gbregman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't solve the real problem. As long as the gateway is in sleep() it can't do anything else. It doesn't matter if the RPC lock is locked or not. As this is not a multi-threaded environment.

@baum baum force-pushed the omap_lock branch 3 times, most recently from 0e60b07 to 6016996 Compare April 18, 2024 11:03
@baum baum changed the title OmapLock: release RPC lock while sleeping Improved Concurrency in Gateway Operations Apr 18, 2024
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@baum baum merged commit e0e8c71 into ceph:devel May 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants