Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Update npm packages #25656

Merged
merged 2 commits into from Jan 11, 2019
Merged

mgr/dashboard: Update npm packages #25656

merged 2 commits into from Jan 11, 2019

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Dec 20, 2018

Signed-off-by: Tiago Melo <tmelo@suse.com>

@callithea
Copy link
Member

Does this PR also fix the below posted issue?

   === npm audit security report ===   
  Run  npm install --save-dev @angular-devkit/build-angular@0.11.4  to resolve 1 vulnerability
  High            Missing Origin Validation                                    
  Package         webpack-dev-server                                            
  Dependency of   @angular-devkit/build-angular [dev]                          
  Path            @angular-devkit/build-angular > webpack-dev-server            
  More info       https://nodesecurity.io/advisories/725                        
 
found 1 high severity vulnerability in 42783 scanned packages
run `npm audit fix` to fix 1 of them.

@tspmelo
Copy link
Contributor Author

tspmelo commented Jan 9, 2019

Update bootstrap in a separate commit to be easier to backport it.

webpack-dev-server problem has been fixed upstream, but for some reason wasn't include in the latest release [1]. I will wait for them to fix it and update again.

angular/angular-cli#13342 (comment)

@LenzGr
Copy link
Contributor

LenzGr commented Jan 9, 2019

Tiago Melo added 2 commits January 9, 2019 22:20
Signed-off-by: Tiago Melo <tmelo@suse.com>
Fixes: https://tracker.ceph.com/issues/37834
Signed-off-by: Tiago Melo <tmelo@suse.com>
Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LenzGr LenzGr merged commit 0cc78cf into ceph:master Jan 11, 2019
@tspmelo tspmelo deleted the wip-npm-update branch January 14, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants