Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] qa: launch interactive shell before test state tearDown #37421

Closed
wants to merge 1 commit into from

Conversation

batrick
Copy link
Member

@batrick batrick commented Sep 25, 2020

This is so tests can properly tear down any state. This solves the
problem of setUp needing to clean up after the previous test because we
did not do a full tear down so interactive mode has something to look
at.

Signed-off-by: Patrick Donnelly pdonnell@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

This is so tests can properly tear down any state. This solves the
problem of setUp needing to clean up after the previous test because we
did not do a full tear down so interactive mode has something to look
at.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick batrick added cephfs Ceph File System tests DNM labels Sep 25, 2020
@batrick
Copy link
Member Author

batrick commented Sep 25, 2020

This is incomplete because tearDown doesn't have access to whether the test failed or passed. I found this solution but I find it unsatisfactory: https://stackoverflow.com/a/39606065

@kotreshhr
Copy link
Contributor

This is incomplete because tearDown doesn't have access to whether the test failed or passed. I found this solution but I find it unsatisfactory: https://stackoverflow.com/a/39606065

Another approach is to use testresources (https://github.com/testing-cabal/testresources) as in testing-cabal/testtools#258 but I found it more complex for our use case. Please have a look at it.

@stale
Copy link

stale bot commented Dec 4, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Dec 4, 2020
@batrick batrick removed the stale label Dec 4, 2020
@batrick batrick marked this pull request as draft December 4, 2020 23:57
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 21, 2021
@djgalloway djgalloway changed the base branch from master to main July 8, 2022 00:00
@github-actions github-actions bot removed the stale label Jul 15, 2022
@batrick batrick closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants