.github/workflows: replace probot-stale with equivalent github action #45230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use probot-stale (https://github.com/probot/stale) to mark stale PRs. According to several issues reported for this repository, there is a widespread problem of probot-state not working properly in github projects (i.e. probot/stale#349). Some users recommend using https://github.com/actions/stale instead. Fixes: https://tracker.ceph.com/issues/54443 Signed-off-by: Laura Flores <lflores@redhat.com>
Config based on this recommendation: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot#example-dependabotyml-file-for-github-actions Signed-off-by: Laura Flores <lflores@redhat.com>
|
jenkins test windows |
|
jenkins test make check |
|
jenkins test api |
|
jenkins test make check |
|
jenkins test make check |
|
@epuertat do you think any permissions need to be explicitly specified as seen here? https://github.com/actions/stale#recommended-permissions I checked our other github action workflows and didn't see a need for it. But let me know what you think. |
|
jenkins test windows |
epuertat
approved these changes
Mar 22, 2022
|
Merging this. I will keep tabs on it to make sure it is working properly as PRs become stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the stale bot code (https://github.com/ceph/ceph/blob/master/.github/stale.yml), PRs should become stale automatically after 60 days of inactivity. After 90 days, they should automatically close. This last part is not working properly; PRs are correctly marked stale, but they fail to close after 90 days.
We currently use probot-stale: https://github.com/probot/stale. According to several issues reported for this repository, there is a widespread problem of probot-stale not working properly in github projects (i.e. probot/stale#349). Some users recommend using https://github.com/actions/stale instead.
This PR proposes a switch from probot-stale to the GitHub stale action workflow.
Fixes: https://tracker.ceph.com/issues/54443
Signed-off-by: Laura Flores lflores@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox