-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus: Spell check the alert descriptions #45254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested review from
aaSharma14 and
nizamial09
and removed request for
a team
March 4, 2022 17:47
mgfritch
approved these changes
Mar 4, 2022
jenkins test make check |
1 similar comment
jenkins test make check |
nizamial09
approved these changes
Mar 15, 2022
sunilangadi2
approved these changes
Mar 15, 2022
epuertat
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot @travisn! What CI tool are you using to catch typos?
jenkins test make check |
jenkins test windows |
jenkins test make check |
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
prometheus-rules-typos
branch
from
March 30, 2022 23:38
63405c6
to
9cca95b
Compare
@nizamial09 test_alerts.yml also updated now, thanks for pointing that out. |
aaSharma14
approved these changes
Apr 1, 2022
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several prometheus alert descriptions had typos. This was caught by the Rook CI when integrating the latest alerts in rook/rook#9837. See the CI spell check failure here.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox