Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: Spell check the alert descriptions #45254

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Mar 4, 2022

Several prometheus alert descriptions had typos. This was caught by the Rook CI when integrating the latest alerts in rook/rook#9837. See the CI spell check failure here.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@travisn travisn requested a review from pcuzner March 4, 2022 17:47
@travisn travisn requested a review from a team as a code owner March 4, 2022 17:47
@travisn travisn requested review from aaSharma14 and nizamial09 and removed request for a team March 4, 2022 17:47
@ljflores
Copy link
Contributor

ljflores commented Mar 5, 2022

jenkins test make check

1 similar comment
@ljflores
Copy link
Contributor

ljflores commented Mar 5, 2022

jenkins test make check

@epuertat epuertat added this to In progress in Dashboard via automation Mar 22, 2022
Dashboard automation moved this from In progress to Reviewer approved Mar 22, 2022
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @travisn! What CI tool are you using to catch typos?

@epuertat
Copy link
Member

jenkins test make check

@epuertat
Copy link
Member

jenkins test windows

@nizamial09
Copy link
Member

@travisn @epuertat it looks like the test_alerts.yml file has the same mistakes

One or more metdata daemons (MDS ranks) are failed or in a

which causes the make check to fail.

@epuertat
Copy link
Member

jenkins test make check

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn
Copy link
Member Author

travisn commented Mar 30, 2022

LGTM! Thanks a lot @travisn! What CI tool are you using to catch typos?

Our github action to spell check can be found here.

@travisn
Copy link
Member Author

travisn commented Mar 30, 2022

@nizamial09 test_alerts.yml also updated now, thanks for pointing that out.

@aaSharma14 aaSharma14 moved this from Reviewer approved to Ready-to-merge in Dashboard Apr 1, 2022
@epuertat epuertat merged commit a98c247 into ceph:master Apr 4, 2022
Dashboard automation moved this from Ready-to-merge to Done Apr 4, 2022
@epuertat
Copy link
Member

epuertat commented Apr 4, 2022

LGTM! Thanks a lot @travisn! What CI tool are you using to catch typos?

Our github action to spell check can be found here.

Thank you, @travisn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
7 participants