Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/cephfs: add test_session_evict_non_blocklisted test case #57458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented May 14, 2024

When evicting the clients or sessions during the
mds_session_blocklist_on_evict option is disabled the clients should reconnect to MDS successfully later after new IOs being sent.

URL: https://tracker.ceph.com/issues/65647

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@lxbsz lxbsz requested a review from a team May 14, 2024 04:58
@github-actions github-actions bot added cephfs Ceph File System tests labels May 14, 2024
@lxbsz
Copy link
Member Author

lxbsz commented May 15, 2024

The qa run

@lxbsz lxbsz force-pushed the wip-session-evict branch 4 times, most recently from bfcbe87 to baac7f4 Compare May 15, 2024 06:23
When evicting the clients or sessions during the
mds_session_blocklist_on_evict option is disabled the clients should
reconnect to MDS successfully later after new IOs being sent.

URL: https://tracker.ceph.com/issues/65647
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented May 15, 2024

The new qa runs, which are all successful.

self.fs.set_max_mds(2)
status = self.fs.wait_for_daemons()

self.fs.set_ceph_conf('client', 'client reconnect stale', True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mds_defer_session_stale defaults to true, i hope this doesn't hamper the test case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the default should be false:

 88 - name: client_reconnect_stale                                                                                                                                                                                                                            
 89   type: bool
 90   level: advanced
 91   desc: reconnect when the session becomes stale
 92   default: false
 93   services:
 94   - mds_client

Isn't it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System tests
Projects
None yet
2 participants