[Squid]rgw/cloud-transition: fix the crash with publish_commit #57466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The obj_state may not be valid anymore post LC operations (esp., cloud-transition). Hence read and store etag prior to them to be used later by notification (publish_commit). Fixes: https://tracker.ceph.com/issues/65862 Signed-off-by: Soumya Koduri <skoduri@redhat.com> (cherry picked from commit e3207e3)
LC Cloud transition should use set_atomic() to prevent any overwrite while updating the HEAD object. Signed-off-by: Soumya Koduri <skoduri@redhat.com> (cherry picked from commit 5be9503)
|
passed qa in https://pulpito.ceph.com/cbodley-2024-05-14_19:08:03-rgw-wip-cbodley2-testing-distro-default-smithi/ but waiting to merge until after the squid rc is cut |
cbodley
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of the mainline fix - #57356
As part of cloud transition, object's head/attrs may get updated and hence state->attrs will not be valid anymore. Fetch obj_state post the transition to access the attrs.
Fixes: https://tracker.ceph.com/issues/65999
Signed-off-by: Soumya Koduri skoduri@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e